mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 56367: Windows: Stout: Adapted `os::killtree` to terminate job objects.
Date Sat, 01 Apr 2017 04:38:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56367/
-----------------------------------------------------------

(Updated April 1, 2017, 4:38 a.m.)


Review request for mesos, John Kordich, Joseph Wu, Li Li, and Michael Park.


Changes
-------

Removed "shim", a derogatory term. (Original comment was redundant too).


Bugs: MESOS-6868
    https://issues.apache.org/jira/browse/MESOS-6868


Repository: mesos


Description
-------

On Windows, a "process tree" is in fact a job object. Thus, the
implementation of `os::killtree` on Windows is an adapter which terminates
the job object corresponding to the process group represented by the
given PID.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/windows/killtree.hpp 15b2faa7b52feeb067004e9b556f06d1acfb9763



Diff: https://reviews.apache.org/r/56367/diff/4/

Changes: https://reviews.apache.org/r/56367/diff/3-4/


Testing
-------

Testing done at end of chain.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message