mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 58126: Windows: Stout: Reimplemented `stringify_args`.
Date Sat, 01 Apr 2017 04:37:20 GMT


> On April 1, 2017, 12:04 a.m., Jeff Coffler wrote:
> > 3rdparty/stout/include/stout/os/windows/shell.hpp
> > Line 179 (original), 179 (patched)
> > <https://reviews.apache.org/r/58126/diff/1/?file=1682877#file1682877line179>
> >
> >     Wow. I'd really like to see unit tests on that, so that we can make sure it
works in cases we care about, and so that if we find special cases down the road, we can make
sure we don't break existing cases.
> >     
> >     Can you please add a unit test to call this with some basic tests as well as
the specific cases that you found to fail?

Yeah, I like unit tests :) It'll just be once I've finished fixing `HealthCheckTest.HealthyTaskNonShell`,
`CombinedAuthenticatorTest.MultipleAuthenticators`, and will come in a batch with those test
fixes.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58126/#review170804
-----------------------------------------------------------


On March 31, 2017, 11:49 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58126/
> -----------------------------------------------------------
> 
> (Updated March 31, 2017, 11:49 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and Michael Park.
> 
> 
> Bugs: MESOS-5418 and MESOS-5522
>     https://issues.apache.org/jira/browse/MESOS-5418
>     https://issues.apache.org/jira/browse/MESOS-5522
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This was an unused function that ended up being the correct place to
> implement proper `argv` concatenation and escaping.  It returns a
> `std::wstring` for use (speifically) by `::CreateProcessW`.  This brings
> us a bit closer to Unicode support within Mesos.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/shell.hpp fdce93c2146ddec6117577b538dca77c416e0c01

> 
> 
> Diff: https://reviews.apache.org/r/58126/diff/1/
> 
> 
> Testing
> -------
> 
> Testing done later in chain.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message