| Joris Van Remoortere |
Re: Review Request 50495: Added PIDGroup module struct. |
Wed, 01 Mar, 18:30 |
| Greg Mann |
Re: Review Request 57177: Clarified naming rules in C++ style guide. |
Wed, 01 Mar, 18:34 |
| Joris Van Remoortere |
Re: Review Request 53700: Refactored `group` in LogProcess into ZooKeeperPIDGroup. |
Wed, 01 Mar, 18:37 |
| Joris Van Remoortere |
Re: Review Request 50496: Added pid group module to `createPIDGroup` method. |
Wed, 01 Mar, 18:37 |
| Joris Van Remoortere |
Re: Review Request 50497: Added new constructors in Log and LogProcess. |
Wed, 01 Mar, 18:37 |
| Joris Van Remoortere |
Re: Review Request 53702: Added a factory method to produce PIDGroup. |
Wed, 01 Mar, 18:37 |
| Joris Van Remoortere |
Re: Review Request 50498: Added --master_pid_group flag in master. |
Wed, 01 Mar, 18:37 |
| Joris Van Remoortere |
Re: Review Request 50499: Added logic in master/main.cpp to use pid_group module. |
Wed, 01 Mar, 18:37 |
| Joris Van Remoortere |
Re: Review Request 53701: Renamed `group` in ZooKeeperPIDGroup to `observer`. |
Wed, 01 Mar, 18:37 |
| Joris Van Remoortere |
Re: Review Request 50493: Added `base` to PIDGroup. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 50838: Updated modules documentation to reflect PIDGroup module. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 52735: Updated comments for killing some garbage containers. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 50128: Overloaded the << operator for `Docker::Device`. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 50947: Only check `gpu/nvidia` isolator for mesos containerizer. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 50599: Assigned Nvidia GPU devices to docker container. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53532: Added `parse` helper function for `Docker::Device`. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 50125: Added `--devices` flag to mesos-docker-executor. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53533: Extended `dockerFlags()` to pass `devices` to mesos-docker-executor. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 46227: Added an user to indicate owner of persistent volume. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 50010: Added example framework for handling inverse offers. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 52980: Updated os::mkdir() to take the mode as an input. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 46230: Updated docs to reflect user in persistent volumes. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53607: Added Seccomp imeplementation. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53608: Added --enable-seccomp flag to configure options. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 54084: Made public Mesos header standalone. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53119: Moved `ns.hpp` to stout [1/2]. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 54104: Adjusted code style in docker executor. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53146: Added a child hook for switching the user. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53147: Made health check run under the same user with tasks. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53120: Moved `ns.hpp` to stout [2/2]. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53121: Added a child hook for entering the target pid's namespaces. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53122: Used child hooks to enter namespaces in health check. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53123: Made `process::defaultClone` private. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53604: Added SeccompInfo protobuf message. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53605: Added --seccomp_profile flag to Mesos agent. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53606: Added `linux/seccomp` isolator. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53695: Allows caching extractable files when outputFile is set. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 46229: Add unit tests for adding a user for persistent volumes. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 46228: Create persistent volume with a supplied user. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53882: Fix configure on FreeBSD. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53479: Perform agent GC asynchronously. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53913: Disable sentinel checks for clang on FreeBSD. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53912: Fix xattr for FreeBSD. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53925: Fix wait macros on FreeBSD. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53926: Move isJailed for FreeBSD into utils. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53927: Check isJailed in tests that call mknod. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 53931: Don't expect an init process in a FreeBSD jail. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 54587: Introduced a ScaleTestContainerizer suitable for scale testing. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 50456: Added custom command to generate Java protobufs. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 50455: Enabled Java builds if Java is found. |
Wed, 01 Mar, 18:38 |
| Joris Van Remoortere |
Re: Review Request 50414: Added variables for building Java Protobuf. |
Wed, 01 Mar, 18:38 |
| Vinod Kone |
Re: Review Request 57177: Clarified naming rules in C++ style guide. |
Wed, 01 Mar, 18:40 |
| Joris Van Remoortere |
Re: Review Request 50457: Added code to generate MesosNativeLibrary.java. |
Wed, 01 Mar, 18:45 |
| Joris Van Remoortere |
Re: Review Request 50458: Added code to build mesos-java.jar. |
Wed, 01 Mar, 18:45 |
| Joris Van Remoortere |
Re: Review Request 50459: Added code to generate JNI Header files. |
Wed, 01 Mar, 18:45 |
| Joris Van Remoortere |
Re: Review Request 50460: Added code to build libstate shared library. |
Wed, 01 Mar, 18:45 |
| Joris Van Remoortere |
Re: Review Request 50463: Added code to build libmesosjava shared library. |
Wed, 01 Mar, 18:45 |
| Joris Van Remoortere |
Re: Review Request 54636: Added LOCAL_IP to disk_full_framework_test.sh. |
Wed, 01 Mar, 18:45 |
| Joris Van Remoortere |
Re: Review Request 50415: Added build step to build Java Protobuf. |
Wed, 01 Mar, 18:45 |
| Joris Van Remoortere |
Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator. |
Wed, 01 Mar, 18:45 |
| Joris Van Remoortere |
Re: Review Request 54655: Renamed LocalNestedContainerObjectApprover for a more generic name. |
Wed, 01 Mar, 18:45 |
| Joris Van Remoortere |
Re: Review Request 54085: Made internal Mesos headers more standalone. |
Wed, 01 Mar, 18:45 |
| Joris Van Remoortere |
Re: Review Request 46425: Add helper function to simplify tokenize handling. |
Wed, 01 Mar, 18:45 |
| Joris Van Remoortere |
Re: Review Request 54769: Fixed a cleanup related bug in the IO switchboard. |
Wed, 01 Mar, 18:45 |
| Joris Van Remoortere |
Re: Review Request 52002: Added helper methods to determine types of disk resources. |
Wed, 01 Mar, 18:45 |
| Joris Van Remoortere |
Re: Review Request 51879: Autodetect value of resource when not specified in static resources. |
Wed, 01 Mar, 18:45 |
| Joris Van Remoortere |
Re: Review Request 53713: Reversed recoursive path creation. |
Wed, 01 Mar, 18:45 |
| Joris Van Remoortere |
Re: Review Request 53707: Added a Windows isolator. Removed `#ifdef`-ed block from Posix. |
Wed, 01 Mar, 18:46 |
| Joris Van Remoortere |
Re: Review Request 51880: Added unit tests to determine disk size for MOUNT or PATH disks. |
Wed, 01 Mar, 18:46 |
| Joris Van Remoortere |
Re: Review Request 50523: Updated docker recovery to account for GPU resources. |
Wed, 01 Mar, 18:46 |
| Joris Van Remoortere |
Re: Review Request 52071: Updated docs to handle resources with no size in agent flags. |
Wed, 01 Mar, 18:46 |
| Joris Van Remoortere |
Re: Review Request 54828: Fixed flags::fetch() to support Windows file paths. |
Wed, 01 Mar, 18:46 |
| Joris Van Remoortere |
Re: Review Request 54693: Add ProtoBuf schema for Blkio cgroup subsystem |
Wed, 01 Mar, 18:46 |
| Joris Van Remoortere |
Re: Review Request 54986: Added metric for slave message queue. |
Wed, 01 Mar, 18:46 |
| Joris Van Remoortere |
Re: Review Request 52064: Support for multiple versions of docs. |
Wed, 01 Mar, 18:46 |
| James Peach |
Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator. |
Wed, 01 Mar, 18:50 |
| Benjamin Mahler |
Re: Review Request 57132: Fixed WebUI data-key. |
Wed, 01 Mar, 18:55 |
| Benjamin Mahler |
Re: Review Request 57132: Fixed WebUI data-key. |
Wed, 01 Mar, 18:56 |
| Mesos Reviewbot |
Re: Review Request 57195: Updated WebUI to display role information of tasks in homepage. |
Wed, 01 Mar, 19:34 |
| Vinod Kone |
Re: Review Request 56016: Added a note about task status updates in scheduler and internal API. |
Wed, 01 Mar, 19:43 |
| Vinod Kone |
Re: Review Request 56017: Added a helper for building a task status from an existing one. |
Wed, 01 Mar, 19:46 |
| Alexander Rukletsov |
Re: Review Request 56017: Added a helper for building a task status from an existing one. |
Wed, 01 Mar, 19:57 |
| Vinod Kone |
Re: Review Request 56017: Added a helper for building a task status from an existing one. |
Wed, 01 Mar, 20:15 |
| Vinod Kone |
Re: Review Request 56208: Updated checks library with general check support. |
Wed, 01 Mar, 20:23 |
| Mesos Reviewbot |
Re: Review Request 57190: Updated agent for hierarchical roles. |
Wed, 01 Mar, 20:29 |
| Ilya Pronin |
Re: Review Request 54081: Added `--pidfile` option to master and agent binaries. |
Wed, 01 Mar, 20:47 |
| Michael Park |
Re: Review Request 57108: Handled the `FrameworkInfo` field added to the `UpdateFrameworkMessage`. |
Wed, 01 Mar, 20:51 |
| Andrew Schwartzmeyer |
Re: Review Request 57052: CMake: Add `build_config.hpp.in` for `BUILD_TIME` variables. |
Wed, 01 Mar, 21:22 |
| Benjamin Mahler |
Re: Review Request 57191: Fixed flakiness in three MULTI_ROLE related tests. |
Wed, 01 Mar, 21:27 |
| Michael Park |
Re: Review Request 57013: Expose offer allocation info within the master /state endpoint. |
Wed, 01 Mar, 21:35 |
| Benjamin Mahler |
Re: Review Request 57194: Updated WebUI to display role information under tab 'Offers'. |
Wed, 01 Mar, 22:08 |
| Andrew Schwartzmeyer |
Re: Review Request 57052: CMake: Add `build_config.hpp.in` for `BUILD_TIME` variables. |
Wed, 01 Mar, 22:18 |
| Andrew Schwartzmeyer |
Re: Review Request 57052: CMake: Add `build_config.hpp.in` for `BUILD_TIME` variables. |
Wed, 01 Mar, 22:20 |
| Mesos Reviewbot |
Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents. |
Wed, 01 Mar, 22:26 |
| Michael Park |
Re: Review Request 57106: Added `FrameworkInfo` to `UpdateFrameworkMessage`. |
Wed, 01 Mar, 23:18 |
| Mesos Reviewbot |
Re: Review Request 55790: Support the full CNI DNS specification. |
Thu, 02 Mar, 00:19 |
| Qian Zhang |
Re: Review Request 57166: Updated role validation for hierarchical roles. |
Thu, 02 Mar, 01:21 |
| Benjamin Mahler |
Re: Review Request 57195: Updated WebUI to display role information of tasks in homepage. |
Thu, 02 Mar, 02:07 |
| Mesos Reviewbot |
Re: Review Request 53369: Agent cgroup assignment should precede agent initialization. |
Thu, 02 Mar, 03:08 |