mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 57513: Cleaned up `strings::tokenize` and `strings::split`.
Date Fri, 31 Mar 2017 21:44:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57513/
-----------------------------------------------------------

(Updated March 31, 2017, 9:44 p.m.)


Review request for mesos and Michael Park.


Changes
-------

Avoid extra scope.


Repository: mesos


Description
-------

The previous coding used a `while` loop condition that was invariant
over the body of the loop; it is clearer to write this as an `if`
statement instead. Also clarified comments.


Diffs (updated)
-----

  3rdparty/stout/include/stout/strings.hpp fe469fa492f179d42794a8ce8f75c0654be7ef58 


Diff: https://reviews.apache.org/r/57513/diff/3/

Changes: https://reviews.apache.org/r/57513/diff/2-3/


Testing
-------

`make check`


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message