mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 57998: Added ResourceProviderID to Resource protos.
Date Fri, 31 Mar 2017 09:38:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57998/
-----------------------------------------------------------

(Updated March 31, 2017, 11:38 a.m.)


Review request for mesos, Jie Yu and Jan Schlicht.


Changes
-------

Addressed comments from Jie and Qian.


Bugs: MESOS-7312
    https://issues.apache.org/jira/browse/MESOS-7312


Repository: mesos


Description
-------

This patch adds an optional resource provider id to resources. In
future changes we will introduce abstract providers of resources.
While currently agents are implicit resource providers, later on an
agent might use multiple resource providers. By having a provider id
in the resource we can unambigously detect which provider contributed
which resource.


Diffs (updated)
-----

  include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac 
  include/mesos/v1/mesos.proto 82d020e05b303a8248a90bc482b76b54b335146c 
  src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a 
  src/tests/resources_tests.cpp 343cab2af225a05e32c5a8bd4a5d9ddfbf76536d 
  src/tests/resources_utils.cpp 2cef55f7312d671307e097c2c4960c8dcf45c1ff 
  src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11 


Diff: https://reviews.apache.org/r/57998/diff/3/

Changes: https://reviews.apache.org/r/57998/diff/2-3/


Testing
-------

make check (OS X, Fedora25)


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message