mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 57564: Changed DRFSorter's representation of inactive clients.
Date Thu, 30 Mar 2017 17:58:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57564/
-----------------------------------------------------------

(Updated March 30, 2017, 5:58 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Michael Park.


Changes
-------

Tweak comments, per review.


Repository: mesos


Description
-------

DRFSorter previously removed inactive clients from the `clients`
collection, and then re-added clients when they were reactivated. This
resulted in resetting the allocation count for the client, which is
unfortunate. This scheme would also be more difficult to adapt to
hierarchical sorting.

This commit changes DRFSorter to continue to store inactive clients in
the `clients`; inactive clients are indicated by a new field in the
`Client` struct, and are omitted from the return value of
`DRFSorter::sort`.


Diffs (updated)
-----

  src/master/allocator/sorter/drf/sorter.hpp 76329220e1115c1de7810fb69b943c78c078be59 
  src/master/allocator/sorter/drf/sorter.cpp ed54680cecb637931fc344fbcf8fd3b14cc24295 
  src/tests/sorter_tests.cpp ec0636beb936d46a253d19322f2157abe95156b6 


Diff: https://reviews.apache.org/r/57564/diff/2/

Changes: https://reviews.apache.org/r/57564/diff/1-2/


Testing
-------

`make check`


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message