mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 58057: Changed SSL Socket destruction into a synchronous operation.
Date Thu, 30 Mar 2017 14:15:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58057/
-----------------------------------------------------------

(Updated March 30, 2017, 7:15 a.m.)


Review request for mesos, Benjamin Mahler and Greg Mann.


Changes
-------

Tweaked dependency chain.


Bugs: MESOS-6919
    https://issues.apache.org/jira/browse/MESOS-6919


Repository: mesos


Description
-------

Previously, the destruction of SSL Sockets was changed from a relatively
simple synchronous delete of data structures, to one where the data
structures are deleted on the event loop.

This implementation lead to the possibility of the socket's file
descriptor out-living the Socket wrapper.  In the case of server
sockets, this potentially allows incoming connections to be made
against a server socket that is considered "closed" (but the FD is
still accepting).

This commit adds a Gate to the SSL Socket to wait for destruction
to finish before returning.  If the SSL Socket's destructor is itself
run on the event loop, the destructor logic is allowed to short-circuit
and run synchronously.


Diffs
-----

  3rdparty/libprocess/src/libevent_ssl_socket.cpp 7d493301bd5c0f24bf89e0b213f07ffe7801508b



Diff: https://reviews.apache.org/r/58057/diff/1/


Testing
-------

See end of chain


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message