mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 58044: Removed unused "using" statements.
Date Thu, 30 Mar 2017 08:36:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58044/#review170550
-----------------------------------------------------------


Ship it!




Jikes, getting these right is even harder than getting includes right due to e.g., ADL. Any
idea how to automate this beyond one-off drive-by fixes?

- Benjamin Bannier


On March 29, 2017, 9:43 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58044/
> -----------------------------------------------------------
> 
> (Updated March 29, 2017, 9:43 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unused "using" statements.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp
1be8c23e62dee7fb2f9bca23e550ab5884ad8b63 
>   src/slave/slave.cpp c8479d7e8eb915284f0ea8cf75f47acd679dee7e 
>   src/tests/http_fault_tolerance_tests.cpp 4040d24e4b910ebda9337f760633e64ede06acf8 
>   src/tests/partition_tests.cpp 3de37d272389f4e33cc246ac2654728ddf59016d 
>   src/tests/sorter_tests.cpp ec0636beb936d46a253d19322f2157abe95156b6 
> 
> 
> Diff: https://reviews.apache.org/r/58044/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message