mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 58042: Remove unused include in libprocess.
Date Thu, 30 Mar 2017 08:36:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58042/#review170546
-----------------------------------------------------------


Ship it!




Not sure fixes like this are worthwhile beyond drive-by adjustments since they are almost
certainly incomplete and not backed by any linting. I'd much rather see implement us e.g.,
iwyu mappings and automate this midterm.

- Benjamin Bannier


On March 29, 2017, 9:43 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58042/
> -----------------------------------------------------------
> 
> (Updated March 29, 2017, 9:43 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Remove unused include in libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/process_tests.cpp 287eb5577896b9d2c6ea7b49247ab54f66e66de8

> 
> 
> Diff: https://reviews.apache.org/r/58042/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message