mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 58058: Moved libprocess initialization of worker threads later.
Date Thu, 30 Mar 2017 01:20:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58058/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Greg Mann.


Bugs: MESOS-6919
    https://issues.apache.org/jira/browse/MESOS-6919


Repository: mesos


Description
-------

This commit moves the creation of all libprocess worker threads
after the creation of the garbage collector process.

This deals with a test-only case where:
  1) Events are queued on the event loop.
  2) Libprocess is finalized as part of the test,
     before processing all events.
  3) Libprocess is reinitialized and the previously queued events
     are allowed to resume.

Because the events were queued in a previous incarnation of
libprocess, they potentially bypass the synchronization variables
in `process::initialize` (i.e. `initialize_complete`) and can
spawn garbage-collected processes before the garbage collector
has been spawned.


Diffs
-----

  3rdparty/libprocess/src/process.cpp f6ee24e2db43d63d91222549efee85421bbf9bf3 


Diff: https://reviews.apache.org/r/58058/diff/1/


Testing
-------

See end of chain


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message