mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 58040: Avoid various redundant copies.
Date Thu, 30 Mar 2017 01:15:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58040/
-----------------------------------------------------------

(Updated March 30, 2017, 1:15 a.m.)


Review request for mesos and Benjamin Bannier.


Repository: mesos


Description (updated)
-------

Spotted using the "performance-unnecessary-copy-initialization"
clang-tidy check.


Diffs (updated)
-----

  src/examples/dynamic_reservation_framework.cpp c1650dc978dddf14cf1e22a33752b58b06914ff4

  src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 
  src/master/master.cpp ab071f56a66ae66c97a185b2377a9cfe9a5c1ade 
  src/oci/spec.cpp 06fceb4f0441431d756eb45c8aaf9730ef9e248a 
  src/tests/default_executor_tests.cpp 6dadd8937eb6809bcb0aca55fab1cb7f17c3262f 


Diff: https://reviews.apache.org/r/58040/diff/2/

Changes: https://reviews.apache.org/r/58040/diff/1-2/


Testing
-------

`make check`


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message