mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.
Date Wed, 29 Mar 2017 20:30:41 GMT


> On March 29, 2017, 12:30 p.m., Andrew Schwartzmeyer wrote:
> > cmake/CompilationConfigure.cmake
> > Lines 38 (patched)
> > <https://reviews.apache.org/r/58014/diff/1/?file=1678211#file1678211line38>
> >
> >     Are we going to enable verbose Cotire logging? It's useful.
> 
> Andrew Schwartzmeyer wrote:
>     (Or note for users that `-DCOTIRE_VERBOSE=1` does the trick.

I'll add `set(COTIRE_VERBOSE ${VERBOSE})`


> On March 29, 2017, 12:30 p.m., Andrew Schwartzmeyer wrote:
> > src/CMakeLists.txt
> > Lines 541 (patched)
> > <https://reviews.apache.org/r/58014/diff/1/?file=1678212#file1678212line541>
> >
> >     Can we add a comment explaining why these specific files are excluded? (As the
reasons are various.)

I can add this before committing.


> On March 29, 2017, 12:30 p.m., Andrew Schwartzmeyer wrote:
> > src/CMakeLists.txt
> > Lines 549 (patched)
> > <https://reviews.apache.org/r/58014/diff/1/?file=1678212#file1678212line549>
> >
> >     Can there be a comment explaining why we use this particular header path versus
alternatives?

I can add this before committing.

(Basically, we mostly care about the agent on Windows, so the sources come from the agent.)


> On March 29, 2017, 12:30 p.m., Andrew Schwartzmeyer wrote:
> > src/CMakeLists.txt
> > Lines 551 (patched)
> > <https://reviews.apache.org/r/58014/diff/1/?file=1678212#file1678212line551>
> >
> >     When are we going to cotire other targets too?

This can be done on a target-by-target basis.  Libmesos is the biggest chunk though, so who
knows?


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58014/#review170451
-----------------------------------------------------------


On March 28, 2017, 5:56 p.m., Jeff Coffler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58014/
> -----------------------------------------------------------
> 
> (Updated March 28, 2017, 5:56 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-7226
>     https://issues.apache.org/jira/browse/MESOS-7226
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This sets several cotire variables in the 'src' directory to enable
> pre-compiled headers for the 'mesos-agent' target. The excluded
> headers were removed due to namespace issues or breaking incremental
> builds.
> 
> All cotire variables are conditionally set if option
> ENABLE_PRECOMPILED_HEADERS is set. In this commit, this is ON for
> WIN32 builds, off for all others.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 5936be07557395ad08b06aa376b5a29f9b11c143 
>   src/CMakeLists.txt b67b512cafd90558abf712a872310ab913fa38ae 
> 
> 
> Diff: https://reviews.apache.org/r/58014/diff/1/
> 
> 
> Testing
> -------
> 
> Testing done at end of chain
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message