mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <>
Subject Re: Review Request 57854: Improved log/failure messages in the (health)checker libraries.
Date Wed, 29 Mar 2017 16:37:30 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 29, 2017, 4:37 p.m.)

Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone.


Fixed another message.

Repository: mesos


- Made log/failure messages consistent across both libraries.
- Task and container IDs are user generated and can contain spaces, so
  we have to wrap them in single quotes.
- Removed the redundant task IDs from 'Failure' messages.

Diffs (updated)

  src/checks/checker.cpp 314354cc374b453ec12e25e3d4730a92697468cf 
  src/checks/health_checker.cpp 2211228f7aa0228af64d8fce6c5f2dd1847328f9 
  src/tests/check_tests.cpp 16f1c07e109e24d475ad593ef1992dfb9f482ba6 




Did some manual testing and looked at the new log messages, they're so much nicer now <3.


Gastón Kleiman

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message