mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 52379: Added agent flag '--oci_store_dir'.
Date Wed, 29 Mar 2017 07:15:41 GMT


> On Feb. 5, 2017, 12:18 p.m., Jie Yu wrote:
> > src/slave/flags.cpp
> > Lines 173 (patched)
> > <https://reviews.apache.org/r/52379/diff/7/?file=1621012#file1621012line173>
> >
> >     Let's make the default /tmp/mesos/store/oci, to be consistent with others.

This was a suggestion of Avinash when he reviewed the design doc, the reason that we do not
choose /tmp/mesos/store/oci is, /tmp is a tmpfs (or ramfs) an in-memory file system, the OCI
images can be quite big (as with docker images) and might end up filling this file system
very fast. And another reason is /tmp will be automatically cleared upon agent host reboot
which is also what we do not want.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52379/#review164265
-----------------------------------------------------------


On Feb. 1, 2017, 9:15 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52379/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2017, 9:15 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-6681
>     https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added agent flag '--oci_store_dir'.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 6a30471d325f35e171e81a687c23fd69e9ec97ee 
>   docs/endpoints/slave/state.json.md 0f82c1926404e79b281b2ea5f4d0ca21323aeded 
>   docs/endpoints/slave/state.md b34459e8624f0b29e927ff79be7fc845ac88080b 
>   src/slave/flags.hpp 2c4bd6ae628a272a4c6c2f02670baef011df4505 
>   src/slave/flags.cpp b48678bae8b3f5bab62710043eaca14ab8370183 
>   src/slave/http.cpp d68c9adc1db43c2e853c8b2290705fdc7739d45c 
> 
> 
> Diff: https://reviews.apache.org/r/52379/diff/7/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message