mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 57972: Added base stout Environment class to mesos-tests Environment class.
Date Wed, 29 Mar 2017 00:37:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57972/#review170354
-----------------------------------------------------------




src/tests/environment.hpp
Line 34 (original), 35 (patched)
<https://reviews.apache.org/r/57972/#comment243178>

    I'd expect there to be a substantial amount of deletions in `src/tests/environment.cpp`.


- Joseph Wu


On March 27, 2017, 3:15 p.m., John Kordich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57972/
> -----------------------------------------------------------
> 
> (Updated March 27, 2017, 3:15 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
> 
> 
> Bugs: MESOS-6731
>     https://issues.apache.org/jira/browse/MESOS-6731
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added base stout Environment class to mesos-tests Environment class.
> 
> 
> Diffs
> -----
> 
>   src/tests/environment.hpp 06b6d54fc76b327e3e26914eb61c16619a36de42 
>   src/tests/main.cpp 5d062c3451bdfb5d5fc459ac7c071ab18e6d8043 
> 
> 
> Diff: https://reviews.apache.org/r/57972/diff/1/
> 
> 
> Testing
> -------
> 
> Ran make check on Linux and the tests on Windows.
> 
> 
> Thanks,
> 
> John Kordich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message