mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 57994: Fixed a regression hiding previously exposed master and agent flags.
Date Tue, 28 Mar 2017 14:01:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57994/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar and Michael Park.


Bugs: MESOS-7316
    https://issues.apache.org/jira/browse/MESOS-7316


Repository: mesos


Description
-------

In f441eb9 we in a number of places changed  how 'Flag's were added to
'Flags' by moving from ad-hoc invocations of 'FlagsBase::add' on
particular instances to proper 'Flags' member variables. This was needed
to ensure 'Flags' instances could always safely be copied. For that we
introduced local derived 'Flags' classes to support localized parsing
needs. At the same time, this implementation strategy led to these these
local variables not being accessible through instances of the original
class anymore (this was inevitable when making 'Flags' classes properly
copyable), which e.g., causes a regression in the flags displayed in a
master's '/flags' endpoint.

This commit moves the flags into the respective base class removing the
local classes so that all passed flags are exposed to users.


Diffs
-----

  src/master/flags.hpp 41a0edfaecf04759f1efa62a9851fbeeb214e84c 
  src/master/flags.cpp b7a129b27bf752bf238d214534364403853c1b36 
  src/master/main.cpp fa7ba1310142a3bef71379ba37fded9b8390aae9 
  src/slave/flags.hpp 224fac1d06d5a3914d4d1408e880458ac5be010e 
  src/slave/flags.cpp 76881536e0058880f5720fbf3c1cebc684508235 
  src/slave/main.cpp 81d61b14accca7611d84db92663a63d5777edd83 


Diff: https://reviews.apache.org/r/57994/diff/1/


Testing
-------

Tested on a number of platforms in internal CI.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message