> On March 22, 2017, 6:31 a.m., Jay Guo wrote:
> > src/webui/master/static/roles.html
> > Lines 28-31 (original), 28-31 (patched)
> > <https://reviews.apache.org/r/57828/diff/1/?file=1671300#file1671300line28>
> >
> > In case quota is not set for a role, should we fill them with zeros in the UI,
or in the backend, much like what we are doing with `weight`.
Let's fill in 0's on the frontend side for now.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57828/#review169674
-----------------------------------------------------------
On March 22, 2017, 6:28 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57828/
> -----------------------------------------------------------
>
> (Updated March 22, 2017, 6:28 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6995
> https://issues.apache.org/jira/browse/MESOS-6995
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Modified WebUI to display quota under `roles` tab.
>
>
> Diffs
> -----
>
> src/webui/master/static/roles.html a8ca03e2533d7bcf5596673c1cd99676bcfb2fae
>
>
> Diff: https://reviews.apache.org/r/57828/diff/1/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> roles quota
> https://reviews.apache.org/media/uploaded/files/2017/03/22/c26212e8-b28f-439f-b756-1114561a935c__Screen_Shot_2017-03-22_at_14.28.10.png
>
>
> Thanks,
>
> Jay Guo
>
>
|