mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <>
Subject Re: Review Request 56364: Windows: Stout: Rewrite job object wrappers.
Date Mon, 27 Mar 2017 22:43:06 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 27, 2017, 10:43 p.m.)

Review request for mesos, John Kordich, Joseph Wu, Li Li, and Michael Park.

Bugs: MESOS-6892

Repository: mesos


`os::create_job` now returns a `Try<SharedHandle>` instead of a raw
`HANDLE`, forcing ownership of the job object handle onto the caller
of the function. `create_job` requires a `std::string name` for the
job object, which is mapped from a PID using `os::name_job`.

The assignment of a process to the job object is now done via
`Try<Nothing> os::assign_job(SharedHandle, pid_t)`.

The equivalent of killing a process tree with job object semantics
is simply to terminate the job object. This is done via


  3rdparty/stout/include/stout/windows/os.hpp 0bedb2d63f5b36afdac2b5a29986f38be96b7c16 


Testing (updated)

Testing done at end of chain.


Andrew Schwartzmeyer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message