mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 56367: Windows: Stout: Shim `os::killtree` to terminate job objects.
Date Mon, 27 Mar 2017 22:42:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56367/
-----------------------------------------------------------

(Updated March 27, 2017, 10:42 p.m.)


Review request for mesos, John Kordich, Joseph Wu, Li Li, and Michael Park.


Changes
-------

Update bug.


Bugs: MESOS-6868
    https://issues.apache.org/jira/browse/MESOS-6868


Repository: mesos


Description
-------

On Windows, a "process tree" is in fact a job object. Thus, the
implementation of `os::killtree` on Windows is a shim which terminates
the job object corresponding to the process group represented by the
given PID.


Diffs
-----

  3rdparty/stout/include/stout/os/windows/killtree.hpp 2be2f8c3d58ee64410f87ee4a4b2bb54fe014748



Diff: https://reviews.apache.org/r/56367/diff/2/


Testing (updated)
-------

Testing done at end of chain.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message