mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 54688: Added a `docker_store_dir` flag to tests.
Date Mon, 27 Mar 2017 20:52:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54688/#review170226
-----------------------------------------------------------




src/tests/environment.cpp
Lines 846-855 (patched)
<https://reviews.apache.org/r/54688/#comment243011>

    I'd prefer we use TestEventListener here so that it's consistent with others:
    ```
    testing::TestEventListener::OnEnvironmentsSetUpEnd
    ```



src/tests/flags.hpp
Lines 170 (patched)
<https://reviews.apache.org/r/54688/#comment243009>

    Can you add a `add` method in the constructor?



src/tests/main.cpp
Lines 161-162 (patched)
<https://reviews.apache.org/r/54688/#comment243007>

    This might break windows tests?



src/tests/main.cpp
Lines 170 (patched)
<https://reviews.apache.org/r/54688/#comment243008>

    why you need path join here?



src/tests/mesos.cpp
Lines 246 (patched)
<https://reviews.apache.org/r/54688/#comment243012>

    Add some comments for this.


- Jie Yu


On Jan. 5, 2017, 10:15 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54688/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2017, 10:15 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-6847
>     https://issues.apache.org/jira/browse/MESOS-6847
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We can use this field to set a docker store directory for the
> `MesosContainerizer` for each test run. This will greatly speed up the
> tests using docker images with the `MesosContainerizer`.
> 
> 
> Diffs
> -----
> 
>   src/tests/environment.cpp a683d8c221635f81906abbead1e01d2469850d93 
>   src/tests/flags.hpp cab24162e26be9fe79c0c65f24e35e3c3d735906 
>   src/tests/main.cpp 5d062c3451bdfb5d5fc459ac7c071ab18e6d8043 
>   src/tests/mesos.cpp adbb697c2bb908a584163dc9954b9e3138164433 
> 
> 
> Diff: https://reviews.apache.org/r/54688/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message