mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 57385: Introduced proto changes needed for the RemoveNestedContainer API call.
Date Mon, 27 Mar 2017 09:31:03 GMT


> On March 8, 2017, 2:04 a.m., Kevin Klues wrote:
> > include/mesos/agent/agent.proto
> > Lines 186 (patched)
> > <https://reviews.apache.org/r/57385/diff/1/?file=1658469#file1658469line187>
> >
> >     Can you move this up to sit underneath the `KillNestedContainer` field. It's
OK that the proto numbers are out of order.

I am sorry to let this pass, but it is not OK to keep these things out of order. It makes
it harder when introducing new ACLs and we have kept them in order for a while (the only in
a different oder is this one).


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57385/#review168225
-----------------------------------------------------------


On March 13, 2017, 1:34 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57385/
> -----------------------------------------------------------
> 
> (Updated March 13, 2017, 1:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-7120
>     https://issues.apache.org/jira/browse/MESOS-7120
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This new Agent API call will make it possible to destroy the sandbox and
> runtime directories of a terminated nested container.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto 9149724159485ea2265e1494c1ce7ef989dad20a 
>   include/mesos/v1/agent/agent.proto 34210c30ca58f50b14ff3e5a01c54003c9705121 
> 
> 
> Diff: https://reviews.apache.org/r/57385/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message