mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 57846: Docker environment gets passed on docker run command.
Date Fri, 24 Mar 2017 02:56:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57846/#review169962
-----------------------------------------------------------


Ship it!




LGTM. You might want to quote the path, as @tillt suggests.

- Adam B


On March 22, 2017, 12:57 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57846/
> -----------------------------------------------------------
> 
> (Updated March 22, 2017, 12:57 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Gilbert Song, James DeFelice,
Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-6951
>     https://issues.apache.org/jira/browse/MESOS-6951
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removes the use of `--env_file` as that does not support newlines in
> environment variable values.
> Removes leaking of possibly sensitive environment variables to the log.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 44fbde8e8a2c6c957af7339b4fb9479af7f21ff7 
> 
> 
> Diff: https://reviews.apache.org/r/57846/diff/2/
> 
> 
> Testing
> -------
> 
> make check & sudo ./bin/mesos-tests.sh
> 
> + functional testing
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message