mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 57854: Improved log/failure messages in the (health)checker libraries.
Date Fri, 24 Mar 2017 00:11:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57854/
-----------------------------------------------------------

(Updated March 24, 2017, 12:11 a.m.)


Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
-------

Updated checks tests.


Bugs: MESOS-6280
    https://issues.apache.org/jira/browse/MESOS-6280


Repository: mesos


Description
-------

- Made log/failure messages consistent across both libraries.
- Task and container IDs are user generated and can contain spaces, so
  we have to wrap them in single quotes.
- Removed the redundant task IDs from 'Failure' messages.


Diffs (updated)
-----

  src/checks/checker.cpp 314354cc374b453ec12e25e3d4730a92697468cf 
  src/checks/health_checker.cpp a26e9b570ea3a0ee775d220a3b523ae7052dad23 
  src/tests/check_tests.cpp f035c16920deaf559420ae0d7d881330ff65ae44 


Diff: https://reviews.apache.org/r/57854/diff/6/

Changes: https://reviews.apache.org/r/57854/diff/5-6/


Testing
-------

Did some manual testing and looked at the new log messages, they're so much nicer now <3.


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message