mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <>
Subject Re: Review Request 57854: Improved log/failure messages in the (health)checker libraries.
Date Thu, 23 Mar 2017 20:19:17 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 23, 2017, 8:19 p.m.)

Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone.


Rebased + moved explicit capture changes to the respective patches

Bugs: MESOS-6280

Repository: mesos


- Made log/failure messages consistent across both libraries.
- Task and container IDs are user generated and can contain spaces, so
  we have to wrap them in single quotes.
- Removed the redundant task IDs from 'Failure' messages.

Diffs (updated)

  src/checks/checker.cpp 314354cc374b453ec12e25e3d4730a92697468cf 
  src/checks/health_checker.cpp a26e9b570ea3a0ee775d220a3b523ae7052dad23 




Did some manual testing and looked at the new log messages, they're so much nicer now <3.


Gastón Kleiman

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message