-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57671/#review169904
-----------------------------------------------------------
Looks good, mostly minor comments.
src/common/http.hpp
Lines 49 (patched)
<https://reviews.apache.org/r/57671/#comment242614>
Modify this comment for jwt?
src/common/http.hpp
Lines 50 (patched)
<https://reviews.apache.org/r/57671/#comment242613>
Does it make sense to have this as `jwt` in lower case since it's a configuration option?
This would be similar to `crammd5` etc.
src/slave/slave.cpp
Lines 111-114 (patched)
<https://reviews.apache.org/r/57671/#comment242615>
Reorder alphabetically?
src/slave/slave.cpp
Lines 274 (patched)
<https://reviews.apache.org/r/57671/#comment242616>
s/loadedHttpAuthenticators/httpAuthenticators?
- Anand Mazumdar
On March 23, 2017, 4:14 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57671/
> -----------------------------------------------------------
>
> (Updated March 23, 2017, 4:14 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-6998
> https://issues.apache.org/jira/browse/MESOS-6998
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the agent initialization code to make use
> of the new `--authenticate_http_executors` flag. When the
> flag is set, authentication is required on the executor realm
> and the JWT authenticator is loaded.
>
>
> Diffs
> -----
>
> src/common/http.hpp a3cfc5d8f0b2e453d5f6c3e485e92dbd643737a3
> src/common/http.cpp ce32ff36ee58b19f2cb11d80e69ab1ff007e75ef
> src/slave/flags.hpp 2c4bd6ae628a272a4c6c2f02670baef011df4505
> src/slave/flags.cpp 4637ca62b257921c1e1f7019864d968f07fca8a1
> src/slave/slave.hpp e2de66cc5b899b8b9a9ea27cc30f19a9e8fc11fb
> src/slave/slave.cpp a4f4a9ca80b726de8e07571fd6d93120947c278b
>
>
> Diff: https://reviews.apache.org/r/57671/diff/7/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
|