mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 57877: WIP: Handled env var in a cross-platform way in check tests.
Date Thu, 23 Mar 2017 15:38:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57877/#review169877
-----------------------------------------------------------




src/tests/check_tests.cpp
Lines 58-63 (patched)
<https://reviews.apache.org/r/57877/#comment242580>

    Instead of local macros, we should probably introduce `exit*` functions in tests that
can take a number and an env var name. Thoughts?


- Alexander Rukletsov


On March 23, 2017, 3:36 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57877/
> -----------------------------------------------------------
> 
> (Updated March 23, 2017, 3:36 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Gastón Kleiman, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/check_tests.cpp f035c16920deaf559420ae0d7d881330ff65ae44 
>   src/tests/health_check_tests.cpp fc1c8281ff8fbb76b7ac510ce36c98db4de4d171 
> 
> 
> Diff: https://reviews.apache.org/r/57877/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message