mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 57775: Ensured check's exit code is interpreted correctly on Windows.
Date Thu, 23 Mar 2017 15:32:54 GMT


> On March 20, 2017, 8:52 p.m., Joseph Wu wrote:
> > src/tests/check_tests.cpp
> > Lines 747-750 (patched)
> > <https://reviews.apache.org/r/57775/diff/2/?file=1668402#file1668402line747>
> >
> >     I don't recognize this test (so I assume it's been added in this chain)...
> >     
> >     Can you assign the TODO to yourself?  Or to me (`josephw`).
> 
> Alexander Rukletsov wrote:
>     It is indeed a new test. Here is where this TODO is coming from. I can assign both
to you : ).
> 
> Alexander Rukletsov wrote:
>     Here is where this TODO is coming from: https://github.com/apache/mesos/blob/05e9a1d40572b8383a582e15663d861b134a7dad/src/tests/health_check_tests.cpp#L1330-L1333

I've disabled tests in other reviews where they were originally introduced.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57775/#review169499
-----------------------------------------------------------


On March 23, 2017, 3:31 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57775/
> -----------------------------------------------------------
> 
> (Updated March 23, 2017, 3:31 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Gastón Kleiman, and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker.cpp 314354cc374b453ec12e25e3d4730a92697468cf 
> 
> 
> Diff: https://reviews.apache.org/r/57775/diff/4/
> 
> 
> Testing
> -------
> 
> make check on Linux and Windows
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message