mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 57695: Kept TaskInfo beyond first scheduler ack in default executor.
Date Thu, 23 Mar 2017 12:10:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57695/
-----------------------------------------------------------

(Updated March 23, 2017, 12:10 p.m.)


Review request for mesos, Anand Mazumdar, Gastón Kleiman, and Vinod Kone.


Changes
-------

Rebased. NNTR.


Bugs: MESOS-7249
    https://issues.apache.org/jira/browse/MESOS-7249


Repository: mesos


Description
-------

Instead of maintaining a separate collection for unacknowledged tasks,
we augment internal `Container` struct by the corresponding `TaskInfo`
and `acknowledged` flag. This way we are still able to find all
unacknowledged tasks (slightly less efficiently as before since now
we have to iterate through all tasks), but also keep `TaskInfo`'s
beyond receiving the first acknowledgement.


Diffs (updated)
-----

  src/launcher/default_executor.cpp 6a885af50db6d489194cc9b780fcf1494e853694 


Diff: https://reviews.apache.org/r/57695/diff/4/

Changes: https://reviews.apache.org/r/57695/diff/3-4/


Testing
-------

See https://reviews.apache.org/r/56218/


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message