mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 57854: Improved log/failure messages in the (health)checker libraries.
Date Thu, 23 Mar 2017 02:42:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57854/#review169831
-----------------------------------------------------------



Bad patch!

Reviews applied: [57854, 57647, 57646, 57645, 55901, 56288, 57648, 57644]

Failed command: python support/apply-reviews.py -n -r 57646

Error:
2017-03-23 02:42:45 URL:https://reviews.apache.org/r/57646/diff/raw/ [12670/12670] -> "57646.patch"
[1]
error: patch failed: src/checks/health_checker.cpp:613
error: src/checks/health_checker.cpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/17528/console

- Mesos Reviewbot


On March 22, 2017, 6:22 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57854/
> -----------------------------------------------------------
> 
> (Updated March 22, 2017, 6:22 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod
Kone.
> 
> 
> Bugs: MESOS-6280
>     https://issues.apache.org/jira/browse/MESOS-6280
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - Made log/failure messages consistent across both libraries.
> - Task and container IDs are user generated and can contain spaces, so
>   we have to wrap them in single quotes.
> - Removed the redundant task IDs from 'Failure' messages.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker.cpp 314354cc374b453ec12e25e3d4730a92697468cf 
>   src/checks/health_checker.cpp a26e9b570ea3a0ee775d220a3b523ae7052dad23 
> 
> 
> Diff: https://reviews.apache.org/r/57854/diff/3/
> 
> 
> Testing
> -------
> 
> Did some manual testing and looked at the new log messages, they're so much nicer now
<3.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message