mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 57646: Made COMMAND health checks resilient to agent failovers.
Date Wed, 22 Mar 2017 19:51:18 GMT


> On March 22, 2017, 4:37 p.m., Alexander Rukletsov wrote:
> > src/checks/health_checker.cpp
> > Lines 513 (patched)
> > <https://reviews.apache.org/r/57646/diff/2/?file=1670858#file1670858line514>
> >
> >     Do you really need to capture `this`?
> 
> Gastón Kleiman wrote:
>     We need it because we use `taskId`, we could cache it.... should we? If so, why is
that prefered?

Improved in https://reviews.apache.org/r/57854/diff/2-3/


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57646/#review169714
-----------------------------------------------------------


On March 22, 2017, 6:19 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57646/
> -----------------------------------------------------------
> 
> (Updated March 22, 2017, 6:19 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod
Kone.
> 
> 
> Bugs: MESOS-6280
>     https://issues.apache.org/jira/browse/MESOS-6280
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made COMMAND health checks resilient to agent failovers.
> 
> 
> Diffs
> -----
> 
>   src/checks/health_checker.hpp 44df544b585b8c9f1138fc69b34b064bae8cc867 
>   src/checks/health_checker.cpp a26e9b570ea3a0ee775d220a3b523ae7052dad23 
> 
> 
> Diff: https://reviews.apache.org/r/57646/diff/3/
> 
> 
> Testing
> -------
> 
> `make check` in Linux
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message