mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 57666: Added the '--authenticate_http_executors' agent flag.
Date Wed, 22 Mar 2017 19:29:17 GMT


> On March 21, 2017, 6:05 p.m., Anand Mazumdar wrote:
> > Looks good. As per our offline discussion, do you want to add the `http_executor_authenticator`
flag to this review or do you intend to do that in a separate review? Either is fine with
me.

After discussing a bit, the argument for a separate flag here is weaker since there are few
cases in which a user will want to set different authenticators for --http_authenticators
and --http_executor_authenticators, due to the default executor's dependence on the operator
API.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57666/#review169588
-----------------------------------------------------------


On March 22, 2017, 7:28 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57666/
> -----------------------------------------------------------
> 
> (Updated March 22, 2017, 7:28 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone.
> 
> 
> Bugs: MESOS-6998
>     https://issues.apache.org/jira/browse/MESOS-6998
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a new agent flag, `--authenticate_http_executors`,
> which requires authentication on the V1 executor API and loads the
> default JWT authenticator.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 9f747406e91840335f97c0166ca75373e47d319b 
>   src/slave/flags.hpp 2c4bd6ae628a272a4c6c2f02670baef011df4505 
>   src/slave/flags.cpp 4637ca62b257921c1e1f7019864d968f07fca8a1 
> 
> 
> Diff: https://reviews.apache.org/r/57666/diff/7/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message