mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 57671: Allowed the agent to require executor authentication.
Date Wed, 22 Mar 2017 19:14:06 GMT


> On March 21, 2017, 4:17 p.m., Anand Mazumdar wrote:
> > src/slave/flags.hpp
> > Line 147 (original), 147 (patched)
> > <https://reviews.apache.org/r/57671/diff/3/?file=1670877#file1670877line147>
> >
> >     This seems to be inconsistent with how we do Framework AuthN for the v1 API.
We had introduced another flag `--http_framework_authenticators`. Can we be consistent here
too?

After discussing a bit, the argument for a separate flag here is weaker since there are few
cases in which a user will want to set different authenticators for `--http_authenticators`
and `--http_executor_authenticators`, due to the default executor's dependence on the operator
API. Dropping this for now.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57671/#review169566
-----------------------------------------------------------


On March 22, 2017, 7:12 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57671/
> -----------------------------------------------------------
> 
> (Updated March 22, 2017, 7:12 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6998
>     https://issues.apache.org/jira/browse/MESOS-6998
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the agent initialization code to make use
> of the new `--authenticate_http_executors` flag. When the
> flag is set, authentication is required on the executor realm
> and the JWT authenticator is loaded.
> 
> 
> Diffs
> -----
> 
>   src/common/http.hpp a3cfc5d8f0b2e453d5f6c3e485e92dbd643737a3 
>   src/common/http.cpp ce32ff36ee58b19f2cb11d80e69ab1ff007e75ef 
>   src/slave/flags.hpp 2c4bd6ae628a272a4c6c2f02670baef011df4505 
>   src/slave/flags.cpp 4637ca62b257921c1e1f7019864d968f07fca8a1 
>   src/slave/slave.hpp e2de66cc5b899b8b9a9ea27cc30f19a9e8fc11fb 
>   src/slave/slave.cpp a4f4a9ca80b726de8e07571fd6d93120947c278b 
> 
> 
> Diff: https://reviews.apache.org/r/57671/diff/6/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message