mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 57788: Changed allocator to skip allocation on weight and quota changes.
Date Wed, 22 Mar 2017 18:36:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57788/
-----------------------------------------------------------

(Updated March 22, 2017, 6:36 p.m.)


Review request for mesos, Adam B, Benjamin Bannier, Benjamin Mahler, and Michael Park.


Changes
-------

Avoided batch allocation on quota changes, updated comments, tweaked tests.


Summary (updated)
-----------------

Changed allocator to skip allocation on weight and quota changes.


Repository: mesos


Description (updated)
-------

Changing weight or quota will no longer trigger a batch allocation.
Since the allocator does not rebalance currently offered resources to
reflect changes to weight or quota, doing a batch allocation is not
useful; instead, the updated quota/weight values will be reflected on
the next allocation.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.cpp 8d54a8cca1bb478f4437f68c5e14f66a9f9bb9e9 
  src/tests/hierarchical_allocator_tests.cpp e343dc37bd7136f0f6dd5dbc22a25cabe715038d 


Diff: https://reviews.apache.org/r/57788/diff/2/

Changes: https://reviews.apache.org/r/57788/diff/1-2/


Testing
-------

`make check`


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message