mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 57647: Made CMD health checks not reuse the check `ContainerID`.
Date Wed, 22 Mar 2017 18:22:12 GMT


> On March 22, 2017, 4:53 p.m., Alexander Rukletsov wrote:
> > src/checks/health_checker.cpp
> > Lines 532-534 (patched)
> > <https://reviews.apache.org/r/57647/diff/2/?file=1670860#file1670860line537>
> >
> >     Why is this failure transient? Can the next retry succeed?

This could happen during an agent failover, and retyring it once the agent comes back should
succeed.


> On March 22, 2017, 4:53 p.m., Alexander Rukletsov wrote:
> > src/checks/health_checker.cpp
> > Lines 548 (patched)
> > <https://reviews.apache.org/r/57647/diff/2/?file=1670860#file1670860line553>
> >
> >     Why is this failure transient? Can the next retry succeed?

This could happen during while an agent is recovering, and retyring it once the agent fully
recovers should succeed.

This could also happen if the root container was already destroyed. In that case it doesn't
make sense to retry, but I think that since the children should be destroyed shortly after,
a stray retry wouldn't hurt.


> On March 22, 2017, 4:53 p.m., Alexander Rukletsov wrote:
> > src/checks/health_checker.cpp
> > Line 536 (original), 588 (patched)
> > <https://reviews.apache.org/r/57647/diff/2/?file=1670860#file1670860line596>
> >
> >     can we still mention `"-health-check"` to simplify reading the logs?

We can, but it won't make Vinod happy ;-).


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57647/#review169729
-----------------------------------------------------------


On March 22, 2017, 6:22 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57647/
> -----------------------------------------------------------
> 
> (Updated March 22, 2017, 6:22 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod
Kone.
> 
> 
> Bugs: MESOS-6280
>     https://issues.apache.org/jira/browse/MESOS-6280
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made CMD health checks not reuse the check `ContainerID`.
> 
> 
> Diffs
> -----
> 
>   src/checks/health_checker.hpp 44df544b585b8c9f1138fc69b34b064bae8cc867 
>   src/checks/health_checker.cpp a26e9b570ea3a0ee775d220a3b523ae7052dad23 
> 
> 
> Diff: https://reviews.apache.org/r/57647/diff/3/
> 
> 
> Testing
> -------
> 
> `make check` in Linux
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message