mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 57647: Made COMMAND health checks not reuse the check `ContainerID`.
Date Wed, 22 Mar 2017 16:53:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57647/#review169729
-----------------------------------------------------------




src/checks/health_checker.cpp
Lines 532-534 (patched)
<https://reviews.apache.org/r/57647/#comment242279>

    Why is this failure transient? Can the next retry succeed?



src/checks/health_checker.cpp
Lines 548 (patched)
<https://reviews.apache.org/r/57647/#comment242280>

    Why is this failure transient? Can the next retry succeed?



src/checks/health_checker.cpp
Line 536 (original), 588 (patched)
<https://reviews.apache.org/r/57647/#comment242275>

    can we still mention `"-health-check"` to simplify reading the logs?


- Alexander Rukletsov


On March 22, 2017, 4:24 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57647/
> -----------------------------------------------------------
> 
> (Updated March 22, 2017, 4:24 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod
Kone.
> 
> 
> Bugs: MESOS-6280
>     https://issues.apache.org/jira/browse/MESOS-6280
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/checks/health_checker.hpp 44df544b585b8c9f1138fc69b34b064bae8cc867 
>   src/checks/health_checker.cpp a26e9b570ea3a0ee775d220a3b523ae7052dad23 
> 
> 
> Diff: https://reviews.apache.org/r/57647/diff/2/
> 
> 
> Testing
> -------
> 
> `make check` in Linux
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message