mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Review Request 57846: Docker environment gets passed by key and invocation environment.
Date Wed, 22 Mar 2017 16:51:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57846/
-----------------------------------------------------------

Review request for mesos, Adam B, Alexander Rukletsov, James DeFelice, Jie Yu, and Joseph
Wu.


Bugs: MESOS-6951
    https://issues.apache.org/jira/browse/MESOS-6951


Repository: mesos


Description
-------

see summary.


Diffs
-----

  src/docker/docker.cpp 44fbde8e8a2c6c957af7339b4fb9479af7f21ff7 


Diff: https://reviews.apache.org/r/57846/diff/1/


Testing
-------

make check & sudo ./bin/mesos-tests.sh

Functional testing - running `ps` while docker test active to confirm we do not leak values
to the commandline;

```
/usr/bin/docker-current -H unix:///var/run/docker.sock run --cpu-shares 1024 --memory 536870912
-e MESOS_CONTAINER_NAME -e MESOS_SANDBOX -v /tmp/DockerContainerizerTest_ROOT_DOCKER_KillOrphanContainers_r7ImX7:/mnt/mesos/sandbox
--net host
```

Further functional testing on variables containing linefeeds in progress...


Thanks,

Till Toenshoff


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message