mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 55901: Added support for command health checks to the default executor.
Date Wed, 22 Mar 2017 15:11:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55901/#review169691
-----------------------------------------------------------


Fix it, then Ship it!





src/checks/health_checker.cpp
Lines 474 (patched)
<https://reviews.apache.org/r/55901/#comment242212>

    Please escape task ids, since they are not generated by Mesos and may contain space.
    
    Also, you don't need to `stringify` `TaskID` here.



src/checks/health_checker.cpp
Lines 601 (patched)
<https://reviews.apache.org/r/55901/#comment242213>

    Please avoid shadowing. `waitFuture`?



src/tests/health_check_tests.cpp
Lines 2191 (patched)
<https://reviews.apache.org/r/55901/#comment242223>

    This will very likely not work on Windows, which is fine for now, because the test is
disabled on Windows.



src/tests/health_check_tests.cpp
Lines 2196-2199 (patched)
<https://reviews.apache.org/r/55901/#comment242217>

    I know this is what `clang-format` suggest, but I'm not sure this formatting is not common
in our codebase. Moreover, it's "jagged". I'd vote for
    ```
    Environment::Variable* variable = healthCheck.mutable_command()->
      mutable_environment()->mutable_variables()->Add();
    ```


- Alexander Rukletsov


On March 21, 2017, 2:01 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55901/
> -----------------------------------------------------------
> 
> (Updated March 21, 2017, 2:01 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod
Kone.
> 
> 
> Bugs: MESOS-6280
>     https://issues.apache.org/jira/browse/MESOS-6280
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/checks/health_checker.hpp 44df544b585b8c9f1138fc69b34b064bae8cc867 
>   src/checks/health_checker.cpp a26e9b570ea3a0ee775d220a3b523ae7052dad23 
>   src/launcher/default_executor.cpp 6a885af50db6d489194cc9b780fcf1494e853694 
>   src/tests/health_check_tests.cpp fc1c8281ff8fbb76b7ac510ce36c98db4de4d171 
> 
> 
> Diff: https://reviews.apache.org/r/55901/diff/16/
> 
> 
> Testing
> -------
> 
> Introduced a new test: `HealthCheckTest.DefaultExecutorCmdHealthCheck`. It passes on
Linux and macOS.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message