mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 57798: Fixed Java V1 Framework unit test for macOS.
Date Wed, 22 Mar 2017 01:23:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57798/#review169657
-----------------------------------------------------------


Ship it!




Ship It!

- Chun-Hung Hsiao


On March 22, 2017, 12:01 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57798/
> -----------------------------------------------------------
> 
> (Updated March 22, 2017, 12:01 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Gilbert Song.
> 
> 
> Bugs: MESOS-7270
>     https://issues.apache.org/jira/browse/MESOS-7270
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a 500ms delay in the main thread to wait for the scheduler driver to stop before
program termination in the Java V1 Framework unit test to avoid test failure under macOS.
> 
> 
> Diffs
> -----
> 
>   src/examples/java/V1TestFramework.java df352ff08c66150483f5be3e52bce150becc7ab2 
> 
> 
> Diff: https://reviews.apache.org/r/57798/diff/2/
> 
> 
> Testing
> -------
> 
> Modified ExamplesTest.V1JavaFramework. Compiled and ran the Java V1 Framework test several
times under macOS 10.12.3 without failure (The test fails before the fix every time). Also
tested under Ubuntu 16.04.2 LTS to verify that the change does not lead to any problem under
Linux.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message