mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 57798: Fixed Java V1 Framework unit test for macOS.
Date Wed, 22 Mar 2017 00:01:23 GMT


> On March 21, 2017, 9:40 p.m., Anand Mazumdar wrote:
> > Looks good! 
> > 
> > Minor Nits:
> > - Can you add some more details about your changes in the `Description` field?
> > - Under `Testing Done`, can you add more details on how did you test this change?

Done. Thanks for the comments.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57798/#review169620
-----------------------------------------------------------


On March 21, 2017, 9:33 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57798/
> -----------------------------------------------------------
> 
> (Updated March 21, 2017, 9:33 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Gilbert Song.
> 
> 
> Bugs: MESOS-7270
>     https://issues.apache.org/jira/browse/MESOS-7270
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed Java V1 Framework unit test for macOS.
> 
> 
> Diffs
> -----
> 
>   src/examples/java/V1TestFramework.java df352ff08c66150483f5be3e52bce150becc7ab2 
> 
> 
> Diff: https://reviews.apache.org/r/57798/diff/2/
> 
> 
> Testing
> -------
> 
> Modified ExamplesTest.V1JavaFramework. Tested under macOS 10.12.3.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message