mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 57798: Fixed Java V1 Framework unit test for macOS.
Date Tue, 21 Mar 2017 20:58:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57798/#review169614
-----------------------------------------------------------


Fix it, then Ship it!




LGTM! Good job, Chun!


src/examples/java/V1TestFramework.java
Lines 382-390 (patched)
<https://reviews.apache.org/r/57798/#comment242056>

    Chun, I am assuming you are using `XXX` here since not sure what is correct in style.
We may probably make it in this way:
    ```
        // NOTE: Copied from src/examples/jave/TestFramework.java:
        // For this test to pass reliably on some platforms, this sleep is
        // required to ensure that the SchedulerDriver teardown is complete
        // before the JVM starts running native object destructors after
        // System.exit() is called. 500ms proved successful in test runs,
        // but on a heavily loaded machine it might not.
        //
        // TODO(greg): Ideally, we would inspect the status of the driver
        // and its associated tasks via the Java API and wait until their
        // teardown is complete to exit.
    ```


- Gilbert Song


On March 20, 2017, 6:19 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57798/
> -----------------------------------------------------------
> 
> (Updated March 20, 2017, 6:19 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Gilbert Song.
> 
> 
> Bugs: MESOS-7270
>     https://issues.apache.org/jira/browse/MESOS-7270
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed Java V1 Framework unit test for macOS. This is the same fix as in https://github.com/apache/mesos/blob/master/src/examples/java/TestFramework.java#L265.
> 
> 
> Diffs
> -----
> 
>   src/examples/java/V1TestFramework.java df352ff08c66150483f5be3e52bce150becc7ab2 
> 
> 
> Diff: https://reviews.apache.org/r/57798/diff/1/
> 
> 
> Testing
> -------
> 
> Modified ExamplesTest.V1JavaFramework. Tested under macOS 10.12.3.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message