mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 57807: Updated 'SchedulerTest.TaskGroupRunning'.
Date Tue, 21 Mar 2017 18:45:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57807/#review169598
-----------------------------------------------------------



Thanks for resolving this TODO. Looks good minus a few minor comments around being consistent
with the default executor tests.


src/tests/scheduler_tests.cpp
Lines 665-670 (patched)
<https://reviews.apache.org/r/57807/#comment242034>

    Can we be consistent with the default executor tests in `default_executor_tests.cpp` that
do similar comparisons via a `hashset`?



src/tests/scheduler_tests.cpp
Lines 675-676 (patched)
<https://reviews.apache.org/r/57807/#comment242036>

    Can we also check if the task Id's match for the finished updates? You should be able
to use the same `hashset` trick I mentioned in my last comment.


- Anand Mazumdar


On March 21, 2017, 2:42 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57807/
> -----------------------------------------------------------
> 
> (Updated March 21, 2017, 2:42 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Benjamin Mahler, and Vinod
Kone.
> 
> 
> Bugs: MESOS-6999
>     https://issues.apache.org/jira/browse/MESOS-6999
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the test `SchedulerTest.TaskGroupRunning`
> to confirm that the agent-side code responsible for launching
> task groups works correctly. Previously, this test only
> verified that the `RunTaskGroupMessage` was sent to the agent.
> 
> 
> Diffs
> -----
> 
>   src/tests/scheduler_tests.cpp 65259b47ec1a2094b23ff448370d30122fd218ca 
> 
> 
> Diff: https://reviews.apache.org/r/57807/diff/1/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this patch chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message