mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 57670: Enabled authentication on the V1 executor API.
Date Tue, 21 Mar 2017 18:13:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57670/#review169592
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/constants.hpp
Lines 145 (patched)
<https://reviews.apache.org/r/57670/#comment242029>

    s/the V1 executor API/HTTP executors
    
    We would have the same realm also for v2 and beyond.



src/slave/constants.hpp
Lines 146 (patched)
<https://reviews.apache.org/r/57670/#comment242028>

    s/mesos-executor/mesos-agent-executor
    
    This would be consistent with other realms both on the agent and the master


- Anand Mazumdar


On March 21, 2017, 4:21 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57670/
> -----------------------------------------------------------
> 
> (Updated March 21, 2017, 4:21 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6998
>     https://issues.apache.org/jira/browse/MESOS-6998
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the `v1/executor` endpoint on the agent to
> route through the correct authentication realm, so that the
> agent may require authentication on the executor API.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp 1f3c543c3782ee09e13de867f30ffa0a161fb6f0 
>   src/slave/http.cpp 1ab6f9475af287a6ac09bc615fa466223a52c97d 
>   src/slave/slave.hpp e2de66cc5b899b8b9a9ea27cc30f19a9e8fc11fb 
>   src/slave/slave.cpp a4f4a9ca80b726de8e07571fd6d93120947c278b 
> 
> 
> Diff: https://reviews.apache.org/r/57670/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message