mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 57664: Added the '--executor_secret_key' agent flag.
Date Tue, 21 Mar 2017 18:07:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57664/#review169591
-----------------------------------------------------------


Fix it, then Ship it!





docs/configuration.md
Lines 1411 (patched)
<https://reviews.apache.org/r/57664/#comment242026>

    Add a comment that this flag only works with SSL builds?


- Anand Mazumdar


On March 21, 2017, 4:23 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57664/
> -----------------------------------------------------------
> 
> (Updated March 21, 2017, 4:23 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-7011
>     https://issues.apache.org/jira/browse/MESOS-7011
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a new agent flag, `--executor_secret_key` to allow the
> specification of a secret key to be used when generating and
> authenticating default executor tokens.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 9f747406e91840335f97c0166ca75373e47d319b 
>   src/slave/flags.hpp 2c4bd6ae628a272a4c6c2f02670baef011df4505 
>   src/slave/flags.cpp 4637ca62b257921c1e1f7019864d968f07fca8a1 
> 
> 
> Diff: https://reviews.apache.org/r/57664/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message