mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 57746: Adjusted namespaces in the tests to prevent collisions.
Date Tue, 21 Mar 2017 14:51:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57746/#review169556
-----------------------------------------------------------




src/tests/fetcher_tests.cpp
Lines 75 (patched)
<https://reviews.apache.org/r/57746/#comment241962>

    Try `using` statements instead of this namespace declaration.


- Greg Mann


On March 21, 2017, 2:50 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57746/
> -----------------------------------------------------------
> 
> (Updated March 21, 2017, 2:50 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone.
> 
> 
> Bugs: MESOS-6999
>     https://issues.apache.org/jira/browse/MESOS-6999
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch alters namespace declarations in the tests in
> order to prevent collisions when Mesos authentication code
> is included.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 29ae1bcf660fb0e03af1d2192484c9ec739f3ef6 
>   src/tests/containerizer/docker_containerizer_tests.cpp 2036cd21d778c80055a82c901736bb3e46cee1a5

>   src/tests/containerizer/io_switchboard_tests.cpp b19961ee91af3c174d4377c2514465d6c99cf331

>   src/tests/containerizer/provisioner_appc_tests.cpp 4342793ed7d3df0e0083c14f6caf7fa247b7b5e7

>   src/tests/fetcher_tests.cpp 27ea7244c713934ef5a721ec133804a006dcb26e 
>   src/tests/health_check_tests.cpp fc1c8281ff8fbb76b7ac510ce36c98db4de4d171 
>   src/tests/master_authorization_tests.cpp 1a0285a3f345ef21a8256d4123d8bb684f538da4 
>   src/tests/slave_authorization_tests.cpp 3657e0a3d19d75cef92e5bf90b65ef00c291b032 
> 
> 
> Diff: https://reviews.apache.org/r/57746/diff/2/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message