mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 57647: Made CMD health checks not reuse the check `ContainerID`.
Date Tue, 21 Mar 2017 14:08:30 GMT


> On March 16, 2017, 1 p.m., Vinod Kone wrote:
> > src/checks/health_checker.hpp
> > Lines 197 (patched)
> > <https://reviews.apache.org/r/57647/diff/1/?file=1665460#file1665460line197>
> >
> >     s/removePreviousCheckContainer/removeNestedContainer/

Removed this method and moved it to `nestedCommandHealthCheck`.


> On March 16, 2017, 1 p.m., Vinod Kone wrote:
> > src/checks/health_checker.cpp
> > Line 546 (original), 557 (patched)
> > <https://reviews.apache.org/r/57647/diff/1/?file=1665461#file1665461line560>
> >
> >     don't think we need "check-" prefix anymore.

I'd like to keep it to make finding the sandbox directory and reading logs when debugging
a bit easier.


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57647/#review169135
-----------------------------------------------------------


On March 15, 2017, 2:59 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57647/
> -----------------------------------------------------------
> 
> (Updated March 15, 2017, 2:59 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod
Kone.
> 
> 
> Bugs: MESOS-6280
>     https://issues.apache.org/jira/browse/MESOS-6280
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See the summary.
> 
> 
> Diffs
> -----
> 
>   src/checks/health_checker.hpp f1f2834b3429fb00cc49c179fa9a3de328f597b5 
>   src/checks/health_checker.cpp 6c97369fd9a567ba16dd92085bf142d43f71eaf1 
> 
> 
> Diff: https://reviews.apache.org/r/57647/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` in Linux
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message