mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 57646: Made COMMAND health checks resilient to agent failovers.
Date Tue, 21 Mar 2017 14:07:28 GMT


> On March 16, 2017, 12:41 p.m., Vinod Kone wrote:
> > src/checks/health_checker.cpp
> > Lines 506 (patched)
> > <https://reviews.apache.org/r/57646/diff/1/?file=1665459#file1665459line506>
> >
> >     Why is that you can't discard a future inside a continuation? Do you mean because
continuations take a const ref? If so, you can just make a copy to discard; we use that pattern
elsewhere (see `detection` future in slave.cpp).
> >     
> >     of course calling `future.discard()` doesn't complete the future but calls its
onDiscard() (note: not onDiscar*ded*()) callback. (although looking at `detection` in slave.cpp,
i'm now confused why discarding the future results in onAny callback being called.)

I refactored all the continuations.


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57646/#review169133
-----------------------------------------------------------


On March 21, 2017, 2:07 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57646/
> -----------------------------------------------------------
> 
> (Updated March 21, 2017, 2:07 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod
Kone.
> 
> 
> Bugs: MESOS-6280
>     https://issues.apache.org/jira/browse/MESOS-6280
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/checks/health_checker.hpp 44df544b585b8c9f1138fc69b34b064bae8cc867 
>   src/checks/health_checker.cpp a26e9b570ea3a0ee775d220a3b523ae7052dad23 
> 
> 
> Diff: https://reviews.apache.org/r/57646/diff/2/
> 
> 
> Testing
> -------
> 
> `make check` in Linux
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message