mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 54954: Improve the warning when failing to find the executor PID.
Date Tue, 21 Mar 2017 00:01:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54954/#review169525
-----------------------------------------------------------



Patch looks great!

Reviews applied: [54954]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Jan. 3, 2017, 5:13 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54954/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2017, 5:13 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When recovering the run state, if we don't find either the libprocess
> PID or the HTTP marker for the executor, that fact was being logged,
> but there was nothing to identify the executor or container. Add the
> framework, executor and container IDs to the message, and clarify that
> we can't find either marker.
> 
> 
> Diffs
> -----
> 
>   src/slave/paths.hpp e64e89678b7d2ab32702edaf5575c92e41fae1e2 
>   src/slave/state.cpp a94bb8d7029295abef70d6595ebc732ac1ab87a8 
> 
> 
> Diff: https://reviews.apache.org/r/54954/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message