mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 57775: Ensured check's exit code is interpreted correctly on Windows.
Date Mon, 20 Mar 2017 20:52:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57775/#review169499
-----------------------------------------------------------




src/checks/checker.cpp
Lines 440-443 (original), 440-448 (patched)
<https://reviews.apache.org/r/57775/#comment241859>

    I'm guessing there's something in this chain that necessitates this change.  Can you explain?
    
    At a glance, these macros should work on Windows:
    ```
    #ifndef WIFEXITED
    #define WIFEXITED(x) ((x) != -1)
    #endif // WIFEXITED
    
    #ifndef WEXITSTATUS
    #define WEXITSTATUS(x) (x & 0xFF)
    #endif // WEXITSTATUS
    ```



src/tests/check_tests.cpp
Lines 747-750 (patched)
<https://reviews.apache.org/r/57775/#comment241860>

    I don't recognize this test (so I assume it's been added in this chain)...
    
    Can you assign the TODO to yourself?  Or to me (`josephw`).


- Joseph Wu


On March 20, 2017, 10:02 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57775/
> -----------------------------------------------------------
> 
> (Updated March 20, 2017, 10:02 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Gastón Kleiman, and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker.cpp 314354cc374b453ec12e25e3d4730a92697468cf 
>   src/tests/check_tests.cpp f035c16920deaf559420ae0d7d881330ff65ae44 
> 
> 
> Diff: https://reviews.apache.org/r/57775/diff/2/
> 
> 
> Testing
> -------
> 
> make check on Linux and Windows
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message