mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 57469: Made the default executor populate volume mappings for disk resources.
Date Mon, 20 Mar 2017 19:13:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57469/#review169484
-----------------------------------------------------------


Fix it, then Ship it!




LGTM!


src/launcher/default_executor.cpp
Lines 344 (patched)
<https://reviews.apache.org/r/57469/#comment241836>

    one more space after `foreach`?



src/tests/default_executor_tests.cpp
Lines 1633 (patched)
<https://reviews.apache.org/r/57469/#comment241838>

    Curious that the `volume` is converted from `resource` to `resources` implicitly?


- Gilbert Song


On March 16, 2017, 11:49 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57469/
> -----------------------------------------------------------
> 
> (Updated March 16, 2017, 11:49 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7225
>     https://issues.apache.org/jira/browse/MESOS-7225
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A task can now access any volumes specified in disk resources from
> its own sandbox owing to the default executor populating the mapping
> from the child container sandbox to the parent. Previously, without
> such a mapping it was not possible for the child container to access
> those volumes mounted on the parent container.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp cbd4f7ecd042e7fa603bd69774d95472df2c896d 
>   src/tests/default_executor_tests.cpp b701e7d2f11af91a94d57db53ac2904e301996f1 
> 
> 
> Diff: https://reviews.apache.org/r/57469/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> The added test uses the new v1 helpers and ideally should not be committed till we do
a sweep of this file to update all the tests. That being said the file is already inconsistent
though.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message