mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 57695: Kept TaskInfo beyond first scheduler ack in default executor.
Date Mon, 20 Mar 2017 16:07:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57695/#review169452
-----------------------------------------------------------


Fix it, then Ship it!





src/launcher/default_executor.cpp
Lines 221 (patched)
<https://reviews.apache.org/r/57695/#comment241800>

    s/acknowledgement/status update acknowledgement/
    
    I haven't tested this, but it seems like we will log a warning for each terminal status
update? I can imagine that being a bit confusing.



src/launcher/default_executor.cpp
Line 274 (original), 288 (patched)
<https://reviews.apache.org/r/57695/#comment241801>

    do you mean `WAIT_NESTED_CONTAINER` here?


- Gastón Kleiman


On March 20, 2017, 11:55 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57695/
> -----------------------------------------------------------
> 
> (Updated March 20, 2017, 11:55 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Gastón Kleiman, and Vinod Kone.
> 
> 
> Bugs: MESOS-7249
>     https://issues.apache.org/jira/browse/MESOS-7249
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of maintaining a separate collection for unacknowledged tasks,
> we augment internal `Container` struct by the corresponding `TaskInfo`
> and `acknowledged` flag. This way we are still able to find all
> unacknowledged tasks (slightly less efficiently as before since now
> we have to iterate through all tasks), but also keep `TaskInfo`'s
> beyond receiving the first acknowledgement.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp cbd4f7ecd042e7fa603bd69774d95472df2c896d 
> 
> 
> Diff: https://reviews.apache.org/r/57695/diff/2/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/56218/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message